Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Code coverage and pre-commit #154

Merged
merged 6 commits into from
Feb 27, 2024
Merged

[CI] Code coverage and pre-commit #154

merged 6 commits into from
Feb 27, 2024

Conversation

christophfroehlich
Copy link
Contributor

  • Use coverage workflow from ros2_control_ci
  • Use pre-commit workflow from ros2_control_ci (combines old format and lint job)

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (d20e2e8) to head (48fde7e).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #154       +/-   ##
===========================================
- Coverage   62.55%   45.63%   -16.92%     
===========================================
  Files           6       12        +6     
  Lines         243      550      +307     
  Branches       85      289      +204     
===========================================
+ Hits          152      251       +99     
- Misses         26       31        +5     
- Partials       65      268      +203
Flag Coverage Δ
unittests 45.63% <ø> (-16.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@christophfroehlich
Copy link
Contributor Author

RHEL on humble fails since the last sync: test_msgs is not found 🤷‍♂️

@christophfroehlich christophfroehlich mentioned this pull request Feb 23, 2024
Merged
destogl
destogl approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@destogl destogl merged commit 8995b49 into ros-controls:master Feb 27, 2024
26 checks passed
@christophfroehlich christophfroehlich deleted the ci_coverage_precommit branch February 27, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

@destogl destogl destogl approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@arne48 arne48 Awaiting requested review from arne48

@bmagyar bmagyar Awaiting requested review from bmagyar

@jaron-l jaron-l Awaiting requested review from jaron-l

@livanov93 livanov93 Awaiting requested review from livanov93

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christophfroehlich @codecov-commenter @fmauch @destogl